[16.0] shopinvader_api_cart: improve convert_to_sale_write #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass the current cart because: * you might need an env * you might need to determine a value based on the current record This we don't need any other hook on the helpers.
1 task
lmignon
approved these changes
Apr 19, 2024
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
On my way to merge this fine PR! |
shopinvader-git-bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
|
Congratulations, your PR was merged at 151d139. Thanks a lot for contributing to shopinvader. ❤️ |
|
It looks like something changed on |
|
Congratulations, your PR was merged at 151d139. Thanks a lot for contributing to shopinvader. ❤️ |
simahawk
added a commit
to camptocamp/odoo-shopinvader
that referenced
this pull request
Apr 23, 2024
Always pass an env or a record. On the same vein of shopinvader#1534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the current cart because:
This way we don't need any other hook on the helpers.
Split from #1521