-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] [IMP] shopinvader_api_sale: Add sale_line router #1508
Open
paradoxxxzero
wants to merge
1
commit into
shopinvader:16.0
Choose a base branch
from
akretion:16.0-imp-shopinvader_api_sale-add-sale_line
base: 16.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[16.0] [IMP] shopinvader_api_sale: Add sale_line router #1508
paradoxxxzero
wants to merge
1
commit into
shopinvader:16.0
from
akretion:16.0-imp-shopinvader_api_sale-add-sale_line
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paradoxxxzero
force-pushed
the
16.0-imp-shopinvader_api_sale-add-sale_line
branch
from
March 5, 2024 14:38
5e21d7d
to
e1c2907
Compare
This was referenced Mar 7, 2024
paradoxxxzero
changed the title
[WIP] [16.0] [IMP] shopinvader_api_sale: Add sale_line router
[16.0] [IMP] shopinvader_api_sale: Add sale_line router
Jun 4, 2024
sebastienbeau
requested changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add more info on lines
paradoxxxzero
force-pushed
the
16.0-imp-shopinvader_api_sale-add-sale_line
branch
from
June 6, 2024 10:55
e1c2907
to
e21f162
Compare
@sebastienbeau can you check the changes? |
@sebastienbeau can you check the changes, pretty please? |
sebastienbeau
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (code review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.