Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] shopinvader_restapi_sale_packaging: extracted from shopinvader_sale_packaging #1416

Merged
merged 1 commit into from
Mar 26, 2024
Merged

[16.0][ADD] shopinvader_restapi_sale_packaging: extracted from shopinvader_sale_packaging #1416

merged 1 commit into from
Mar 26, 2024

Conversation

marielejeune
Copy link
Contributor

@marielejeune marielejeune commented Oct 3, 2023 •
edited
Loading

Extensions of restapi sale and cart services for using packages.
Extracted from shopinvader_sale_packaging

@marielejeune marielejeune marked this pull request as draft October 3, 2023 10:15
@marielejeune marielejeune force-pushed the 16.0-shopinvader_restapi_sale_packaging branch 3 times, most recently from d91583d to 5f1540a Compare October 3, 2023 13:35
@marielejeune marielejeune changed the title [ADD] shopinvader_restapi_sale_packaging: extracted from shopinvader_sale_packaging [16.0][ADD] shopinvader_restapi_sale_packaging: extracted from shopinvader_sale_packaging Oct 5, 2023
@marielejeune marielejeune force-pushed the 16.0-shopinvader_restapi_sale_packaging branch 3 times, most recently from 54089ae to 78fc8f6 Compare October 18, 2023 08:19
simahawk
simahawk reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

shopinvader_restapi_sale_packaging/__manifest__.py Outdated Show resolved Hide resolved
@marielejeune marielejeune force-pushed the 16.0-shopinvader_restapi_sale_packaging branch from 78fc8f6 to 3a1a804 Compare October 18, 2023 12:12
@marielejeune marielejeune marked this pull request as ready for review October 18, 2023 12:15
@marielejeune marielejeune mentioned this pull request Oct 20, 2023
Closed
ivantodorovich
ivantodorovich approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the dependencies have been merged.

This needs a rebase and it should be good to go

@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@marielejeune marielejeune force-pushed the 16.0-shopinvader_restapi_sale_packaging branch from 3a1a804 to 35f91cc Compare February 14, 2024 14:47
@marielejeune
Copy link
Contributor Author

I've rebased and removed merged dependencies from test-requirements

@simahawk
Copy link
Contributor

/ocabot merge minor

@shopinvader-git-bot
Copy link

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1416-by-simahawk-bump-minor, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit d42fe00 into shopinvader:16.0 Mar 26, 2024
3 checks passed
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at f3ca66f. Thanks a lot for contributing to shopinvader. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk left review comments

@cyrilmanuel cyrilmanuel cyrilmanuel approved these changes

@ivantodorovich ivantodorovich ivantodorovich approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marielejeune @shopinvader-git-bot @simahawk @ivantodorovich @cyrilmanuel