Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [MIG] shopinvader_product_brand #1408

Merged
merged 3 commits into from
Oct 13, 2023
Merged

[16.0] [MIG] shopinvader_product_brand #1408

merged 3 commits into from
Oct 13, 2023

Conversation

marielejeune
Copy link
Contributor

@marielejeune marielejeune commented Sep 22, 2023 •
edited
Loading

  • Remove bindings between shopinvader.backend and product.brand
  • Add a Pydantic schema for product.brand indexation and extend ShopinvaderProduct schema.
  • Split into 2 modules: shopinvader_product_brand (for schemas) and shopinvader_search_engine_product_brand (for serializer)

Depends on #1390

TODO

  • description fields must now be Text fields
  • add redirect_url_key field to brand schema.
  • Investigate where is url_builder field, if it is still needed and what to do with related fields / domains in view
  • Add tests for serializer

@marielejeune marielejeune mentioned this pull request Sep 22, 2023
Merged
@sebastienbeau sebastienbeau added this to the 16.0 milestone Sep 25, 2023
@marielejeune marielejeune force-pushed the 16.0-mig_shopinvader_product_brand branch 8 times, most recently from cab9cf6 to c86174b Compare October 3, 2023 07:08
@lmignon lmignon mentioned this pull request Oct 3, 2023
Merged
2 tasks
@lmignon lmignon force-pushed the 16.0-mig_shopinvader_product_brand branch from c86174b to d9d617d Compare October 3, 2023 17:09
@marielejeune marielejeune force-pushed the 16.0-mig_shopinvader_product_brand branch 3 times, most recently from 67b9b37 to 74355ad Compare October 5, 2023 09:44
@lmignon lmignon force-pushed the 16.0-mig_shopinvader_product_brand branch from 74355ad to ce5adfc Compare October 13, 2023 10:41
@lmignon lmignon force-pushed the 16.0-mig_shopinvader_product_brand branch from ce5adfc to eda7ea4 Compare October 13, 2023 10:53
@lmignon
Copy link
Collaborator

lmignon commented Oct 13, 2023

/ocabot merge nobump

@shopinvader-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1408-by-lmignon-bump-nobump, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit 53603ce into shopinvader:16.0 Oct 13, 2023
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 6eb9cf6. Thanks a lot for contributing to shopinvader. ❤️

@lmignon lmignon deleted the 16.0-mig_shopinvader_product_brand branch October 13, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@marielejeune @lmignon @shopinvader-git-bot @sebastienbeau