Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new verify and parse interface #127

Merged
merged 18 commits into from
Oct 8, 2023

Conversation

shogo82148
Copy link
Owner

The current Parse function does not verify the alg, iss, and sub claims. By introducing a new Parser structure, it makes it easier to verify these claims.

The current Parse function does not verify the alg, iss, and sub claims. By introducing a new Parser structure, it makes it easier to verify these claims.
@coveralls
Copy link

coveralls commented Oct 8, 2023

Pull Request Test Coverage Report for Build 6445434741

  • 161 of 204 (78.92%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 77.061%

Changes Missing Coverage Covered Lines Changed/Added Lines %
jws/key_finder.go 7 9 77.78%
jws/verifier.go 41 45 91.11%
jwt/parser.go 112 149 75.17%
Totals Coverage Status
Change from base Build 6430607648: 0.03%
Covered Lines: 7421
Relevant Lines: 9630

💛 - Coveralls

@shogo82148 shogo82148 merged commit e11514d into main Oct 8, 2023
17 checks passed
@shogo82148 shogo82148 deleted the introduce-new-verify-interface branch October 8, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants