support AWS_METADATA_SERVICE envs on EC2 #530
reviewdog [golangci] report
reported by reviewdog 🐶
Findings (0)
Filtered Findings (29)
xray/xraylog/log.go|168 col 11| Error return value of l.w.Write
is not checked (errcheck)
xray/test_daemon.go|180 col 19| Error return value of td.conn.ReadFrom
is not checked (errcheck)
xray/xrayslog/xrayslog.go|150 col 12| Error return value of l.h.Handle
is not checked (errcheck)
xraysql/conn.go|99 col 17| Error return value of tx.Rollback
is not checked (errcheck)
xraysql/tx_test.go|50 col 20| Error return value of tx.Rollback
is not checked (errcheck)
xraysql/tx_test.go|191 col 20| Error return value of tx.Rollback
is not checked (errcheck)
xrayhttp/client_test.go|1119 col 14| Error return value of conn.Read
is not checked (errcheck)
xrayhttp/client_tracer.go|147 col 32| SA1019: state.NegotiatedProtocolIsMutual has been deprecated since Go 1.16 because it shouldn't be used: this value is always true. (staticcheck)
xrayhttp/client_tracer.go|163 col 7| SA1019: tls.VersionSSL30 has been deprecated since Go 1.13 because it shouldn't be used: SSLv3 is cryptographically broken, and is no longer supported by this package. See golang.org/issue/32716. (staticcheck)
xrayhttp/handler.go|260 col 14| SA1019: http.CloseNotifier has been deprecated since Go 1.11 and an alternative has been available since Go 1.7: the CloseNotifier interface predates Go's context package. New code should use Request.Context instead. (staticcheck)
xrayhttp/client_test.go|1110 col 39| SA1019: e.Temporary has been deprecated since Go 1.18 because it shouldn't be used: Temporary errors are not well-defined. Most "temporary" errors are timeouts, and the few exceptions are surprising. Do not use this method. (staticcheck)
xrayhttp/wrap_test.go|23 col 19| SA1019: http.CloseNotifier has been deprecated since Go 1.11 and an alternative has been available since Go 1.7: the CloseNotifier interface predates Go's context package. New code should use Request.Context instead. (staticcheck)
xrayhttp/wrap_test.go|47 col 19| SA1019: http.CloseNotifier has been deprecated since Go 1.11 and an alternative has been available since Go 1.7: the CloseNotifier interface predates Go's context package. New code should use Request.Context instead. (staticcheck)
xraysql/conn.go|94 col 14| SA1019: conn.Conn.Begin has been deprecated since Go 1.8: Drivers should implement ConnBeginTx instead (or additionally). (staticcheck)
xraysql/conn.go|150 col 27| SA1019: driver.Execer has been deprecated since Go 1.8: Drivers should implement ExecerContext instead. (staticcheck)
xraysql/conn.go|194 col 28| SA1019: driver.Queryer has been deprecated since Go 1.8: Drivers should implement QueryerContext instead. (staticcheck)
xraysql/connector.go|326 col 15| SA1019: stmt.Query has been deprecated since Go 1.8: Drivers should implement StmtQueryContext instead (or additionally). (staticcheck)
xraysql/stmt.go|49 col 17| SA1019: stmt.Stmt.Exec has been deprecated since Go 1.8: Drivers should implement StmtExecContext instead (or additionally). (staticcheck)
xraysql/stmt.go|81 col 17| SA1019: stmt.Stmt.Query has been deprecated since Go 1.8: Drivers should implement StmtQueryContext instead (or additionally). (staticcheck)
xraysql/stmt.go|88 col 28| SA1019: driver.ColumnConverter has been deprecated since Go 1.9: Drivers should implement NamedValueChecker. (staticcheck)
xraysql/fakedb_ctx_test.go|123 col 7| SA1019: driver.Execer has been deprecated since Go 1.8: Drivers should implement ExecerContext instead. (staticcheck)
xraysql/fakedb_ctx_test.go|125 col 7| SA1019: driver.Queryer has been deprecated since Go 1.8: Drivers should implement QueryerContext instead. (staticcheck)
xraysql/fakedb_ctx_test.go|131 col 7| SA1019: driver.ColumnConverter has been deprecated since Go 1.9: Drivers should implement NamedValueChecker. (staticcheck)
xraysql/fakedb_ext_test.go|18 col 7| SA1019: driver.Execer has been deprecated since Go 1.8: Drivers should implement ExecerContext instead. (staticcheck)
xraysql/fakedb_ext_test.go|19 col 7| SA1019: driver.Queryer has been deprecated since Go 1.8: Drivers should implement QueryerContext instead. (staticcheck)
xraysql/fakedb_ext_test.go|21 col 7| SA1019: driver.ColumnConverter has been deprecated since Go 1.9: Drivers should implement NamedValueChecker. (staticcheck)
xray/lambda_test.go|21 col 31| SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)
xray/lambda_test.go|55 col 31| SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)
xray/segment_test.go|87 col 49| SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)