Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix short generator #238

Merged
merged 3 commits into from
Dec 5, 2021
Merged

fix short generator #238

merged 3 commits into from
Dec 5, 2021

Conversation

shogo82148
Copy link
Owner

rand.Read(buf) is used in some places, but it doesn't guarantee to fill buf.
io.ReadFull(rand.Reader, buf) should be used instead of it.

@shogo82148
fix short generator
a310733 
`rand.Read(buf)` is used in some places, but it doesn't guarantee to fill `buf`.
`io.ReadFull(rand.Reader, buf)` should be used instead of it.
@coveralls
Copy link

coveralls commented Dec 5, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.09%) to 66.425% when pulling 7e1ebd1 on fix-request-id-generator into 5771aec on main.

@shogo82148 shogo82148 merged commit 12c0716 into main Dec 5, 2021
@shogo82148 shogo82148 deleted the fix-request-id-generator branch December 5, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shogo82148 @coveralls