New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connector implements io.Closer #184

Merged

shogo82148 merged 1 commit into main from sql-connector-implements-closer

Jul 2, 2021

Owner

shogo82148 commented Jun 27, 2021

from Go 1.17, the DB.Close method closes the connector field.

https://tip.golang.org/doc/go1.17#database/sql
The DB.Close method now closes the connector field if the type in this field implements the io.Closer interface.

https://tip.golang.org/pkg/database/sql/driver/#Connector
If a Connector implements io.Closer, the sql package's DB.Close method will call Close and return error (if any).


          Connector implements io.Closer

coveralls commented Jun 27, 2021

Coverage increased (+0.04%) to 66.475% when pulling 1948651 on sql-connector-implements-closer into abcfd0a on main.

shogo82148 merged commit add24dc into main

shogo82148 deleted the sql-connector-implements-closer branch

July 2, 2021 05:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet