fix(sort): support empty strings when sorting

shlomiassaf · May 19, 2021 · 6a1023e · 6a1023e
1 parent 20e1e61
commit 6a1023e
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/libs/ngrid/core/src/lib/data-source/triggers/sort/sort.ts b/libs/ngrid/core/src/lib/data-source/triggers/sort/sort.ts
@@ -26,12 +26,17 @@ export function applySort<T>(column: PblColumnDefinition, sort: PblNgridSortDefi
 
 function defaultSorter<T>(column: PblColumnDefinition, sort: PblNgridSortInstructions, data: T[]): T[] {
   return data.sort((a, b) => {
+    const directionMultiplier = (sort.order === 'asc' ? 1 : -1);
     let valueA = getValue(column, a);
     let valueB = getValue(column, b);
 
     valueA = isNaN(+valueA) ? valueA : +valueA;
     valueB = isNaN(+valueB) ? valueB : +valueB;
 
-    return (valueA < valueB ? -1 : valueA === valueB ? 0 : 1) * (sort.order === 'asc' ? 1 : -1);
+    if (valueA && valueB) {
+      return (valueA < valueB ? -1 : valueA === valueB ? 0 : 1) * directionMultiplier;
+    }
+
+    return (valueA ? 1 : -1) * directionMultiplier;
   });
 }