Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce duplication in actions listing visits #2276

Merged

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Nov 20, 2024

All actions that return a list of visits are 70% equal. This PR extracts the common logic to an abstract action which all concrete actions extend from.

@acelaya acelaya force-pushed the feature/visits-list-duplication branch from d5de747 to 980608d Compare November 20, 2024 08:46
@acelaya acelaya force-pushed the feature/visits-list-duplication branch from 980608d to d7e300e Compare November 20, 2024 08:48
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.68%. Comparing base (81bed53) to head (d7e300e).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2276      +/-   ##
=============================================
- Coverage      93.70%   93.68%   -0.02%     
+ Complexity      1657     1655       -2     
=============================================
  Files            274      275       +1     
  Lines           5780     5764      -16     
=============================================
- Hits            5416     5400      -16     
  Misses           364      364              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@acelaya acelaya merged commit b2bfe97 into shlinkio:develop Nov 20, 2024
31 checks passed
@acelaya acelaya deleted the feature/visits-list-duplication branch November 20, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant