Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for city name dynamic redirects #2263

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Nov 14, 2024

Closes #1774

Add a new type of condition for the dynamic rule-based redirection system.

This condition checks if the city name resulting of geolocating current visitor matches configured one.

This condition will never match if geolocation is not configured, or it is disabled, and there's always a chance of a visitor to be incorrectly geolocated, so there's a small chance of false negatives/positives.

The city name is also not validated, so human errors or typos would also result in incorrect matchings.

Additionally, Shlink won't warn you if geolocation is not configured/enabled when a condition of this type is created.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.70%. Comparing base (7ddb3e7) to head (a6e0916).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2263      +/-   ##
=============================================
+ Coverage      93.68%   93.70%   +0.01%     
- Complexity      1647     1655       +8     
=============================================
  Files            272      272              
  Lines           5768     5781      +13     
=============================================
+ Hits            5404     5417      +13     
  Misses           364      364              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit 1fee745 into shlinkio:develop Nov 14, 2024
31 checks passed
@acelaya acelaya deleted the feature/geolocation-city-name-redirects branch November 14, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geolocation-based dynamic redirection
1 participant