Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/env var command #2220

Merged
merged 7 commits into from
Oct 14, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Oct 13, 2024

Closes #2212

Provide a new hidden CLI command that returns the value of an env var for current env, but making sure the fallback for _FILE env vars is evaluated for that env var.

This allows to call this command from any script in order to get the actual value for the env var, even if that's not a PHP script.

Additionally, use this new command in the docker entry point script, to read environment variables there but retaining the _FILE fallback logic.

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.79%. Comparing base (1773e6e) to head (f118ea2).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2220      +/-   ##
=============================================
+ Coverage      94.73%   94.79%   +0.06%     
- Complexity      1551     1591      +40     
=============================================
  Files            269      270       +1     
  Lines           5200     5266      +66     
=============================================
+ Hits            4926     4992      +66     
  Misses           274      274              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit aef04af into shlinkio:develop Oct 14, 2024
31 checks passed
@acelaya acelaya deleted the feature/env-var-command branch October 14, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INITIAL_API_KEY_FILE not working as documented
1 participant