Ensure query parameters are preserved verbatim when forwarded to long URL #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
force-pushed
the
feature/fix-query-params
branch
from
698bafc
to
1ed55c0
Compare
acelaya
commented
Oct 10, 2024
| @@ -7,7 +7,7 @@ return [ | |||
| 'rabbitmq' => [ | |||
| 'enabled' => true, | |||
| 'host' => 'shlink_rabbitmq', | |||
| 'port' => '5672', | |||
| 'port' => 5672, | |||
There was a problem hiding this comment.
This change is unrelated to this PR, but it was causing an error when connecting to RabbitMQ.
Production config was not affected, as the port was converted to int in there.
acelaya
force-pushed
the
feature/fix-query-params
branch
from
1ed55c0
to
1773e6e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2214 +/- ##
==========================================
Coverage 94.73% 94.73%
Complexity 1551 1551
==========================================
Files 269 269
Lines 5200 5200
==========================================
Hits 4926 4926
Misses 274 274 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2213
When merging request query params with the long URL ones, right before redirecting, this PR makes sure the request ones are parsed manually so that they are preserved verbatim.
By using
$request->getQueryParams()we were getting affected by a historical decisions in PHP, where query params are promoted as vars, and therefore, characters not allowed in variable names (like spaces) where replaced by something else.Since we do not rely in this side effect, manually parsing the query string prevents this behavior and preserves params with "special" chars verbatim.