Fix MEMORY_LIMIT being ignored when provided as installer config option
#2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… promoted to env vars
acelaya
force-pushed
the
feature/fix-memory-limit
branch
from
3b7f421
to
447ccca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2203 +/- ##
=============================================
- Coverage 95.88% 94.73% -1.16%
Complexity 1551 1551
=============================================
Files 269 269
Lines 5200 5200
=============================================
- Hits 4986 4926 -60
- Misses 214 274 +60 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2201
Make
MEMORY_LIMIToption be read as env var after config has been loaded, to make sure config from the installer has been promoted as env vars at that point.