Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying the redis database index to be used #2184

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Aug 25, 2024

Closes #2183

Update shlink-common to bring support for redis database selection.

Additionally, fix visit count trackers to properly work with changes introduced in doctrine/dbal 4.1

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 95.88%. Comparing base (69dcab9) to head (187c173).
Report is 6 commits behind head on develop.

Files Patch % Lines
...re/src/Visit/Listener/OrphanVisitsCountTracker.php 25.00% 3 Missing ⚠️
.../src/Visit/Listener/ShortUrlVisitsCountTracker.php 25.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2184      +/-   ##
=============================================
- Coverage      95.99%   95.88%   -0.12%     
- Complexity      1549     1551       +2     
=============================================
  Files            269      269              
  Lines           5198     5200       +2     
=============================================
- Hits            4990     4986       -4     
- Misses           208      214       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit 9afc787 into shlinkio:develop Aug 26, 2024
29 checks passed
@acelaya acelaya deleted the feature/redis-db-index branch August 26, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying the redis database index to be used
1 participant