Revert "Remove unneeded DISTINCT from list short URLs query" #2118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2117
The
DISTINCT
is actually needed, but there's no test covering the combination in which it is.When filtering short URLs by tags or by search term, the query needs to join with the tags table, in which case the results are not correct without the
DISTINCT
.The right fix here would be something in the lines of:
DISTINCT
only when strictly needed, to reduce the performance impact in some cases at least.A test covering this case needs to be added.