Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/modernize entities #2068

Merged
merged 6 commits into from
Mar 18, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Mar 18, 2024

Closes #2034

Modernize entities to use constructor property promotion and readonly whenever possible.

@acelaya acelaya marked this pull request as ready for review March 18, 2024 19:23
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 91.58879% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 97.36%. Comparing base (053e026) to head (cd38732).
Report is 1 commits behind head on develop.

Files Patch % Lines
module/Core/src/Visit/Entity/VisitLocation.php 68.00% 8 Missing ⚠️
...dule/CLI/src/Command/Visit/LocateVisitsCommand.php 75.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2068      +/-   ##
=============================================
+ Coverage      97.34%   97.36%   +0.01%     
+ Complexity      1363     1349      -14     
=============================================
  Files            251      251              
  Lines           4827     4780      -47     
=============================================
- Hits            4699     4654      -45     
+ Misses           128      126       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit 457a7a1 into shlinkio:develop Mar 18, 2024
22 of 23 checks passed
@acelaya acelaya deleted the feature/modernize-entities branch March 18, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor entities to use as many readonly props as possible
1 participant