Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when redirecting to a non-http URL #2063

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Mar 15, 2024

Closes #2060

Fix an error when trying to redirect to a non-http URL (like the ones used for deeplinks, for example).

This PR also adds a bunch of tests covering that, as this was a regression introduced in https://github.com/shlinkio/shlink/pull/1991/files#diff-abf169189b40a92b43093bda1780b27f63581b5fc9c4644fca78c5913773acd8

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (293725f) to head (053e026).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2063   +/-   ##
==========================================
  Coverage      97.34%   97.34%           
  Complexity      1363     1363           
==========================================
  Files            251      251           
  Lines           4826     4827    +1     
==========================================
+ Hits            4698     4699    +1     
  Misses           128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit 98992c6 into shlinkio:develop Mar 15, 2024
23 checks passed
@acelaya acelaya deleted the feature/non-http-url branch March 15, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported scheme error
1 participant