-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support Symfony 7 #93
Conversation
Thanks! Can you also adapt the Github workflow so the tests are executed with Sf 7, too? |
I tried adjusting the github workflow - but it won't work (yet). The newer dev-master of nyholm/symfony-bundle-test supports symfony 7, but this version breaks backwards-compatibility (Class "Nyholm\BundleTest\BaseBundleTestCase" doesn't exist anymore). So if anyone can offer a solution to this dependency-chaos - you're most welcome! |
Dropping the support for unmaintained versions of Sf would be fine for me if it allows to keep the code more simple. |
any progress on this? :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you squash all the commits together to one?
Sorry, for the delay and thanks for your patience!
Done!
no worries - thanks for maintaining the bundle! |
@dontub can you take another look for us 👀. That would be highly appreciated |
It's now released as 4.1.0. |
updated composer symfony packages version constraints to support symfony 7