Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Symfony 7 #93

Merged
merged 1 commit into from
Mar 16, 2024
Merged

support Symfony 7 #93

merged 1 commit into from
Mar 16, 2024

Conversation

sorrx
Copy link
Contributor

@sorrx sorrx commented Dec 18, 2023

updated composer symfony packages version constraints to support symfony 7

@dontub
Copy link
Collaborator

dontub commented Dec 23, 2023

Thanks! Can you also adapt the Github workflow so the tests are executed with Sf 7, too?

@sorrx
Copy link
Contributor Author

sorrx commented Dec 23, 2023

I tried adjusting the github workflow - but it won't work (yet). The newer dev-master of nyholm/symfony-bundle-test supports symfony 7, but this version breaks backwards-compatibility (Class "Nyholm\BundleTest\BaseBundleTestCase" doesn't exist anymore).
I don't know, if or how it's possible, to tell phpunit to use different tests for different symfony versions/installed packages.
Alternatively the BundleInitializationTest.php has to be rewritten to match the new dependencies - but that would exclude older symfony versions < 5.4 from testing.

So if anyone can offer a solution to this dependency-chaos - you're most welcome!

@dontub
Copy link
Collaborator

dontub commented Dec 27, 2023

Dropping the support for unmaintained versions of Sf would be fine for me if it allows to keep the code more simple.

@xvilo
Copy link

xvilo commented Jan 12, 2024

any progress on this? :D

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
src/Resources/config/services_test.xml Outdated Show resolved Hide resolved
tests/BundleInitializationTest.php Outdated Show resolved Hide resolved
tests/BundleInitializationTest.php Outdated Show resolved Hide resolved
@sorrx sorrx requested a review from dontub January 17, 2024 11:15
src/Resources/config/services_test.xml Outdated Show resolved Hide resolved
tests/BundleInitializationTest.php Outdated Show resolved Hide resolved
tests/BundleInitializationTest.php Outdated Show resolved Hide resolved
Copy link
Collaborator

@dontub dontub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash all the commits together to one?

Sorry, for the delay and thanks for your patience!

@sorrx
Copy link
Contributor Author

sorrx commented Mar 7, 2024

Can you squash all the commits together to one?

Done!

Sorry, for the delay and thanks for your patience!

no worries - thanks for maintaining the bundle!

@xvilo xvilo mentioned this pull request Mar 15, 2024
@xvilo
Copy link

xvilo commented Mar 15, 2024

@dontub can you take another look for us 👀. That would be highly appreciated

@dontub dontub merged commit de3b1d7 into shivas:master Mar 16, 2024
14 checks passed
@dontub
Copy link
Collaborator

dontub commented Mar 16, 2024

It's now released as 4.1.0.
Thanks @sorrx for sticking at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants