-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset download/conversion #99
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
…ommit.ci wanted to do
…t.ci stop imposing its brain damage
for more information, see https://pre-commit.ci
…t is the case in another script
…not hurt to have this
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not add these configs to the main repo? This seems to be very dataset specific. Or do you think it is better to have it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the one's that are publically available are fine, but perhaps mm-conv etc. are not publically available right now. So lets put the ones that are publically available. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for the moment, I'll cut out the en-us ones into their own pull request. The rest need extra language bits.
What does this PR do?
This adds scripts to download and convert LJspeech, hificaptain, and mcspeech.
The download locations for LJspeech and hificaptain were made to match what was in the existing yaml files, though hificaptain needs some tweaking.
Before submitting
pytest
command?pre-commit run -a
command?Did you have fun?
Make sure you had fun coding 🙃