Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset download/conversion #99

Open
wants to merge 77 commits into
base: main
Choose a base branch
from

Conversation

jimregan
Copy link
Contributor

@jimregan jimregan commented Oct 1, 2024

What does this PR do?

This adds scripts to download and convert LJspeech, hificaptain, and mcspeech.

The download locations for LJspeech and hificaptain were made to match what was in the existing yaml files, though hificaptain needs some tweaking.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not add these configs to the main repo? This seems to be very dataset specific. Or do you think it is better to have it here?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the one's that are publically available are fine, but perhaps mm-conv etc. are not publically available right now. So lets put the ones that are publically available. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for the moment, I'll cut out the en-us ones into their own pull request. The rest need extra language bits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants