Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Add-Path for self-hosted Windows #609

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

dino182
Copy link
Contributor

@dino182 dino182 commented Jun 27, 2022


name: 🐞 Bug Fix
about: PATH for the current procees needs to be updated with the newly installed php location
labels: bug


A Pull Request should be associated with a Discussion.

If you're fixing a bug, adding a new feature or improving something please provide the details in discussions,
so that the development can be pointed in the intended direction.

Related discussion: #608

Further notes in Contribution Guidelines
Thank you for your contribution.

Description

This PR adds the location of the newly installed php tools to the PATH environment variable so that the current Powershell process can find them.

In case this PR introduced TypeScript/JavaScript code changes:

  • I have written test cases for the changes in this pull request
  • I have run npm run format before the commit.
  • I have run npm run lint before the commit.
  • I have run npm run release before the commit.
  • npm test returns with no unit test errors and all code covered.

In case this PR edits any scripts:

  • I have checked the edited scripts for syntax.
  • I have tested the changes in an integration test (If yes, provide workflow YAML and link).

YAML

https://github.com/dino182/setup-php-testing/blob/2024ca4915dc4382028faf8e1bbd8984521564a3/.github/workflows/test.yml

Failed run

https://github.com/dino182/setup-php-testing/runs/7044714697?check_suite_focus=true

Successful run

https://github.com/dino182/setup-php-testing/runs/7044919837?check_suite_focus=true#step:2:23

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #609 (1a2cb4f) into develop (5915ccd) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop      #609   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          529       529           
  Branches        78        78           
=========================================
  Hits           529       529           
Impacted Files Coverage Δ
src/tools.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4969814...1a2cb4f. Read the comment docs.

@shivammathur shivammathur merged commit 3fda17f into shivammathur:develop Jun 27, 2022
@shivammathur
Copy link
Owner

shivammathur commented Jun 27, 2022

Thanks for fixing this. Merged 🎉

@dino182 dino182 deleted the develop branch June 27, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants