Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 migration #938

Merged
merged 16 commits into from
Nov 1, 2020
Merged

v3 migration #938

merged 16 commits into from
Nov 1, 2020

Conversation

shirou
Copy link
Owner

@shirou shirou commented Sep 7, 2020

Thanks @Lomanic , PR count gradually becomes lower and golang mod becomes enables by default, I am thinking about migration to v3 (finally, sorry)

This PR includes migration scripts from current v2 to v3. to use this script, bash tools/v3migration/v3migration.sh with go build environment.

issues

All issues should be also filed in #362.

schedule

  • ~ 2020-09-30:Collect issues with breaking changes. implement migration script. adding v3 to this PR is not permitted. so we can merge PR into current v2 if no breaking change.
  • 2020-09-30: Add v3 directory to this PR
  • ~ 2020-10-31: Start to implement complex change by hand.
  • 2020-10-31: Release v3.20.10

@shirou shirou added the v3 label Sep 7, 2020
@shirou shirou changed the title v3 migration [WIP] v3 migration Sep 7, 2020
@shirou
Copy link
Owner Author

shirou commented Oct 11, 2020

@Lomanic
Copy link
Collaborator

Lomanic commented Oct 15, 2020

Maybe this PR should target a new v3 branch, this way we could be iterating in this branch in smaller steps. What do you think @shirou?

@shirou
Copy link
Owner Author

shirou commented Oct 15, 2020

Thank you foe the comment. I think v3 directory in master branch is better to follow go module manner. so this PR targets master branch.

and after merge this PR, we can still develop v2 because different directory.

@shirou
Copy link
Owner Author

shirou commented Oct 16, 2020

@shirou shirou force-pushed the feature/migration_to_v3 branch 2 times, most recently from 9ba5d2a to 8dbd29c Compare October 26, 2020 13:16
@shirou shirou changed the title [WIP] v3 migration v3 migration Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants