-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3 migration #938
Merged
Merged
v3 migration #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe this PR should target a new |
Thank you foe the comment. I think v3 directory in and after merge this PR, we can still develop v2 because different directory. |
|
shirou
force-pushed
the
feature/migration_to_v3
branch
from
October 18, 2020 09:49
427fb64
to
e264326
Compare
shirou
force-pushed
the
feature/migration_to_v3
branch
2 times, most recently
from
October 26, 2020 13:16
9ba5d2a
to
8dbd29c
Compare
shirou
force-pushed
the
feature/migration_to_v3
branch
from
October 31, 2020 14:40
cf010b1
to
8e2446b
Compare
shirou
force-pushed
the
feature/migration_to_v3
branch
from
November 1, 2020 04:28
84b339b
to
407a11a
Compare
This was referenced Nov 1, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @Lomanic , PR count gradually becomes lower and golang mod becomes enables by default, I am thinking about migration to v3 (finally, sorry)
This PR includes migration scripts from current v2 to v3. to use this script,
bash tools/v3migration/v3migration.sh
with go build environment.issues
All issues should be also filed in #362.
process.NetIoCounter()
(process.NetIOCounters is pointless on Linux #429)WithContext
methods ([Windows] cpu.Info() timing out #469)process.GetWin32Proc
should not be exposedprocess.State
(as[]string, err
), instead of just one state (currently, R: Running S: Sleep T: Stop I: Idle Z: Zombie W: Wait and L: Lock). Linked to Determine if process is running in the foreground #596 (determining background state, see Determine if process is running in the foreground #596 (comment))(string, error)
, and returns NotImplementError for other platformsLabel
, change return type to(string, error)
, and returns NotImplementError for other platforms andString()
output for network lists #226schedule
v3.20.10