cpu: support for DragonflyBSD #893
Conversation
cpu/cpu_dragonfly.go
Outdated
| var featuresMatch = regexp.MustCompile(`Features=.+<(.+)>`) | ||
| var featuresMatch2 = regexp.MustCompile(`Features2=[a-f\dx]+<(.+)>`) | ||
| var cpuEnd = regexp.MustCompile(`^Trying to mount root`) | ||
| var cpuCores = regexp.MustCompile(`FreeBSD/SMP: (\d*) package\(s\) x (\d*) core\(s\)`) |
There was a problem hiding this comment.
sorry, I don't have a Dragonfly, so I can not check but is this FreeBSD correct ?
There was a problem hiding this comment.
Good catch. I just checked, and parsing the dmesg output is unlikely to work on FreeBSD, too, as regular users do not have access to dmesg. I'll remove this regexp because it will never match, and the correct value is eventually extracted in InfoWithContext.
There was a problem hiding this comment.
ok, I see why you parse the output of dmesg: to differentiate cpu vs. cores.
There was a problem hiding this comment.
Thank you for the information. I found it is not worked correctly in FreeBSD... it should be use kern.sched.topology_spec to getting how many psychical core it has. I will fix it, so we can left this at this time.
There was a problem hiding this comment.
I have rewritten the PR to use the equivalent hw.cpu_topology.tree in DragonflyBSD. Looking forward to seeing what you come up with on the FreeBSD side.
|
Thank you for your contribution!. However, this file seems exactly same as If this works, it's ok to add, but could you change the |
Co-authored-by: shirou <[email protected]>
|
The PR works, at least on my machines ;) There are indeed some issues with parsing the number of cores, I'm going to check if it's possible to extract that information without parsing the output of |
|
I can not confirm this can works, but I merge it. Thank you for your great contribution! |
No description provided.