Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable more linters, report coverage and cache mods #1205

Merged
merged 25 commits into from
Dec 29, 2021
Merged

enable more linters, report coverage and cache mods #1205

merged 25 commits into from
Dec 29, 2021

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Dec 22, 2021

This enables durationcheck, gofmt, gofumpt, misspell, unparam linters

@mmorel-35 mmorel-35 marked this pull request as ready for review December 23, 2021 00:29
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@b1186a6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1205   +/-   ##
=========================================
  Coverage          ?   44.97%           
=========================================
  Files             ?       51           
  Lines             ?     8058           
  Branches          ?        0           
=========================================
  Hits              ?     3624           
  Misses            ?     3980           
  Partials          ?      454           
Flag Coverage Δ
Linux 40.38% <0.00%> (?)
Windows 41.17% <0.00%> (?)
go-1.16.x 44.84% <0.00%> (?)
go-1.17.x 44.97% <0.00%> (?)
macOS 43.47% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1186a6...fe2fab4. Read the comment docs.

@mmorel-35 mmorel-35 changed the title enable more linters enable more linters, report coverage and cache mods Dec 23, 2021
Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@shirou shirou merged commit 2f8da0a into shirou:master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants