Fix bug in README.md #228
Merged
Fix bug in README.md #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per https://vuejs.org/guide/essentials/template-refs.html#accessing-the-refs, "you can only access the ref after the component is mounted". Therefore `this.createTour()` which uses `this.$ref.el` should be called in `mounted()` instead of `created()`
|
@lcb931023 |
|
Um, I don't think that's true. Please see vuejs's lifecycle diagram here:
|
|
Apologies, I don't know where I read that. You are correct. |
RobbieTheWagner
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://vuejs.org/guide/essentials/template-refs.html#accessing-the-refs, "you can only access the ref after the component is mounted". Therefore
this.createTour()which usesthis.$ref.elshould be called inmounted()instead ofcreated()