Added showOn options parameter function #78
Conversation
Implemented a version of @geekjuice comment in regards to skipping tours that don't find their target element. Reference to: #65
I'm not sure about this commit, but if it creates a conflict on merge, it's generated so it's easy to resolve.
| }); | ||
| if (typeof next.options.showOn !== 'undefined' && !next.options.showOn()) { | ||
| const index = this.steps.indexOf(next); | ||
| var nextIndex = forward ? index + 1 : index - 1; |
There was a problem hiding this comment.
One minor detail. var here should be const.
|
Other than the small comment above, I think you can go ahead and minor version bump this to Once that's done, I'll go ahead and merge this. Thanks again for being patience while I was on hiatus 👍 |
@geekjuice suggested declaring nextIndex as a const.
gulp version:minor to 1.2.0
css output diffs that were generated appear to be line endings. Omitting build output of: dist/css/*.css dist/eager/installHelper.js
|
Great! Thanks for reviewing it. I've committed your feedback, bumped the version, and committed the install output. I really enjoy these tours and if I run into something else I'll send it your way. |
|
🎉 👍 |
Added showOn options parameter function
|
Is there no documentation for |
|
I guess not... :( I didn't know where to submit the changes to the documentation. But what is it you want to know about it? Basically you have to define the showOn option as a function that returns a boolean. If it is defined, when the step is stepped to it will execute the function and look at the return value to decide whether or not the step should be shown. If it shouldn't be, it will skip to the next one. |
We have conditionally shown controls on our site and didn't want to have to make individual tours for different user types. Please take a look at this proposed update inspired by Issue 65.
#65
JsFiddle showing it in action:
http://jsfiddle.net/mattgibbs/f8n0gLrL/4/