Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use data attributes for element selection in demo/tests #273

Closed
BrianSipple opened this issue Oct 13, 2018 · 4 comments
Closed

Use data attributes for element selection in demo/tests #273

BrianSipple opened this issue Oct 13, 2018 · 4 comments

Comments

@BrianSipple
Copy link
Contributor

This will make our testing much less brittle — and set a good example for users of Shepherd.

(Cy, among many sources, knows what's up).

@RobbieTheWagner
Copy link
Member

This would be great! I'm used to using them in Ember via ember-test-selectors. Is there a package that is not Ember specific that will strip them out of production builds for us?

@BrianSipple
Copy link
Contributor Author

@rwwagner90 I think this would just apply to the demo app and test dummy app. Aren't we already keeping all of that code out of the production build?

@RobbieTheWagner
Copy link
Member

@BrianSipple yeah, good point. That works then 👍

@stale
Copy link

stale bot commented Jan 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants