Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all of popper.js placement values are supported #259

Closed
tedbeer opened this issue Oct 2, 2018 · 2 comments
Closed

Not all of popper.js placement values are supported #259

tedbeer opened this issue Oct 2, 2018 · 2 comments
Labels
enhancement

Comments

@tedbeer
Copy link
Contributor

tedbeer commented Oct 2, 2018

From the source code I see extracting top|left|right|bottom|center values from the attachTo option.
According to the popper.js API the placement option may have the following values:

  • auto
  • top
  • bottom
  • left
    and each value can have a variation: -start or -end

Issues:

  1. the center value is not supported by popper.js
  2. the auto value is not supported by shepherd.js
  3. none of the modifiers are supported by shepherd.js
@RobbieTheWagner
Copy link
Member

@tedbeer good catch! We should probably rewrite the parsePosition function a bit, and be able to support this. Would you be interested in submitting a PR for that?

tedbeer pushed a commit to tedbeer/shepherd that referenced this issue Oct 3, 2018
Support placement values and modifiers according to popper.js API (sh…
303fc98 
…ipshapecode#259)
RobbieTheWagner pushed a commit that referenced this issue Oct 7, 2018
@tedbeer @RobbieTheWagner
Support placement values and modifiers according to popper.js API (#259…
e3e95ec 
…) (#260)
@tedbeer tedbeer mentioned this issue Oct 8, 2018
Merged
@BrianSipple
Copy link
Contributor

Closed by #260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tedbeer @RobbieTheWagner @BrianSipple