Skip to content
This repository has been archived by the owner on Dec 15, 2020. It is now read-only.

This addon seems to be unmaintained - alternative: ember-cli-release-tag #77

Closed
mydea opened this issue Jan 16, 2019 · 7 comments · Fixed by #79
Closed

This addon seems to be unmaintained - alternative: ember-cli-release-tag #77

mydea opened this issue Jan 16, 2019 · 7 comments · Fixed by #79

Comments

@mydea
Copy link
Collaborator

mydea commented Jan 16, 2019

Since this addon seems to be unmaintained, and dependencies are woefully out of date, I made a forked, modernized version of this, ember-cli-release-tag.

Since there have been no responses to any issues and PRs for months (or years), and we do use that functionality somewhat often, I decided to make a mostly drop-in replacement with a more modern codebase and dependencies.

For now, this new addon is a bit streamlined and I have removed some options:

  • The date strategy does not accept any additional arguments anymore - it is always v19.01.16. Feel free to provide your own custom strategy if needed.
  • NPM publishing is not included right now
  • For semver, premajor and preminor have been dropped. Instead, always use prerelease, which you can combine with major (--> pre-major) or minor (--> pre-minor), e.g. ember release --major --prerelease='beta'
  • You have to confirm before the release commit is created (see Don't do anything before confirmation #67)

See #71 , #72, #69

For most common use cases, it should be enough to do

yarn remove ember-cli-release
yarn add ember-cli-release-tag

And continue as before.

@rwjblue
Copy link
Contributor

rwjblue commented Jun 20, 2019

FWIW, I personally use release-it (along with lerna-changelog) these days. I made a handy dandy boostrapping package to make it easier to get started (npm init rwjblue-release-it-setup in any package):

https://github.com/rwjblue/create-rwjblue-release-it-setup

@RobbieTheWagner
Copy link
Member

@mydea would you be interested in helping merge that functionality in here, rather than forking? I'm happy to add you as a maintainer.

@jacobq
Copy link

jacobq commented Sep 22, 2019

@rwwagner90 FWIW there is also adopted-ember-addons (more info) if you find that you don't have time to maintain the addon but want it to continue living on for those using it.

@mydea
Copy link
Collaborator Author

mydea commented Sep 23, 2019

I could try to add my changes here, but it is basically a complete re-write which tries to keep a similar (but not 100% matching) API surface.

Overall, I wonder if it is worth it, vs. just recommending to use release-it as @rwjblue recommended - which is a non-Ember specific solution to this problem, which actually also offers even more functionality. Maybe we should push the community to use that instead...?

@jelhan
Copy link
Contributor

jelhan commented Oct 1, 2019

Overall, I wonder if it is worth it, vs. just recommending to use release-it as @rwjblue recommended - which is a non-Ember specific solution to this problem, which actually also offers even more functionality. Maybe we should push the community to use that instead...?

Just started to use release-it the first time. It has a ton of features I missed on ember-cli-release. I think it's time to drop another ember-specific solution in favor of the established tool in the non-ember world.

@RobbieTheWagner
Copy link
Member

I could be in favor of suggesting release-it. Never used it before myself, but if @rwjblue likes it, it must be okay 😃

@elwayman02
Copy link
Contributor

release-it is fantastic, this RB is a great template for how to quickly and easily add it to any project:

ember-modifier/ember-modifier#16

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants