Disable mixed calls diagnosis for trackMixedCalls: false (#109)

shipmonk-rnd · Nov 5, 2024 · bcfa0a0 · bcfa0a0
1 parent a3ddfe2
commit bcfa0a0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/rules.neon b/rules.neon
@@ -74,6 +74,7 @@ services:
             - phpstan.diagnoseExtension
         arguments:
             reportTransitivelyDeadMethodAsSeparateError: %shipmonkDeadCode.reportTransitivelyDeadMethodAsSeparateError%
+            trackCallsOnMixed: %shipmonkDeadCode.trackCallsOnMixed%
 
 
 parameters:

diff --git a/src/Rule/DeadMethodRule.php b/src/Rule/DeadMethodRule.php
@@ -79,6 +79,8 @@ class DeadMethodRule implements Rule, DiagnoseExtension
 
     private bool $reportTransitivelyDeadMethodAsSeparateError;
 
+    private bool $trackCallsOnMixed;
+
     /**
      * @var array<string, array{string, int}> methodKey => [file, line]
      */
@@ -96,11 +98,13 @@ class DeadMethodRule implements Rule, DiagnoseExtension
 
     public function __construct(
         ClassHierarchy $classHierarchy,
-        bool $reportTransitivelyDeadMethodAsSeparateError
+        bool $reportTransitivelyDeadMethodAsSeparateError,
+        bool $trackCallsOnMixed
     )
     {
         $this->classHierarchy = $classHierarchy;
         $this->reportTransitivelyDeadMethodAsSeparateError = $reportTransitivelyDeadMethodAsSeparateError;
+        $this->trackCallsOnMixed = $trackCallsOnMixed;
     }
 
     public function getNodeType(): string
@@ -558,7 +562,7 @@ private function isNeverReportedAsDead(string $methodKey): bool
 
     public function print(Output $output): void
     {
-        if ($this->mixedCalls === [] || !$output->isDebug()) {
+        if ($this->mixedCalls === [] || !$output->isDebug() || !$this->trackCallsOnMixed) {
             return;
         }
 

diff --git a/tests/Rule/DeadMethodRuleTest.php b/tests/Rule/DeadMethodRuleTest.php
@@ -54,6 +54,7 @@ protected function getRule(): DeadMethodRule
             $this->rule = new DeadMethodRule(
                 new ClassHierarchy(),
                 !$this->emitErrorsInGroups,
+                true,
             );
         }