User関係の型をUserLiteとUserDetailedに整理 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poppingmoon
added a commit
to poppingmoon/miria
that referenced
this pull request
Oct 15, 2023
poppingmoon
force-pushed
the
user
branch
4 times, most recently
from
40b5d71 to
20d8572
Compare
poppingmoon
added a commit
to poppingmoon/miria
that referenced
this pull request
Oct 16, 2023
poppingmoon
added a commit
to poppingmoon/miria
that referenced
this pull request
Oct 19, 2023
poppingmoon
force-pushed
the
user
branch
8 times, most recently
from
8bcd03a to
ff5d367
Compare
poppingmoon
added a commit
to poppingmoon/miria
that referenced
this pull request
Oct 21, 2023
poppingmoon
force-pushed
the
user
branch
2 times, most recently
from
21daa77 to
0e76da0
Compare
poppingmoon
added a commit
to poppingmoon/miria
that referenced
this pull request
Oct 30, 2023
poppingmoon
force-pushed
the
user
branch
2 times, most recently
from
dcab24b to
5f4ca5b
Compare
poppingmoon
added a commit
to poppingmoon/miria
that referenced
this pull request
Nov 4, 2023
poppingmoon
added a commit
to poppingmoon/miria
that referenced
this pull request
Nov 4, 2023
poppingmoon
added a commit
to poppingmoon/miria
that referenced
this pull request
Nov 4, 2023
poppingmoon
added a commit
to poppingmoon/miria
that referenced
this pull request
Nov 7, 2023
poppingmoon
added a commit
to poppingmoon/miria
that referenced
this pull request
Nov 11, 2023
poppingmoon
force-pushed
the
user
branch
2 times, most recently
from
8c8cc32 to
9295a71
Compare
poppingmoon
added a commit
to poppingmoon/miria
that referenced
this pull request
Nov 24, 2023
poppingmoon
added a commit
to poppingmoon/miria
that referenced
this pull request
Nov 26, 2023
poppingmoon
added a commit
to poppingmoon/miria
that referenced
this pull request
Dec 3, 2023
poppingmoon
added a commit
to poppingmoon/miria
that referenced
this pull request
Dec 4, 2023
poppingmoon
added a commit
to poppingmoon/miria
that referenced
this pull request
Dec 17, 2023
poppingmoon
force-pushed
the
user
branch
3 times, most recently
from
0f7117c to
ec5aebf
Compare
poppingmoon
added a commit
to poppingmoon/miria
that referenced
this pull request
Dec 19, 2023
poppingmoon
added a commit
to poppingmoon/miria
that referenced
this pull request
Dec 22, 2023
poppingmoon
added a commit
to poppingmoon/miria
that referenced
this pull request
Dec 22, 2023
poppingmoon
added a commit
to poppingmoon/miria
that referenced
this pull request
Dec 24, 2023
poppingmoon
added a commit
to poppingmoon/miria
that referenced
this pull request
Jan 21, 2024
shiosyakeyakini-info
merged commit d91ad3b
into
shiosyakeyakini-info:master
3 checks passed
|
マージしました！ありがとうございます |
poppingmoon
added a commit
to poppingmoon/miria
that referenced
this pull request
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Userに関するクラスが
User,UsersShowResponse,IResponseに重複して存在していることによって、同じ名前のフィールドが一方ではString, 他方ではEnumとして定義されるといったことを解消し、予防するために整理しましたUserはUserLiteになりましたUsersShowResponseとIResponseはUserDetailedになりましたUserDetailedは 3つのクラスに実装されていますUserDetailedNotMeはログインせずに他者に対してusers/showを呼んだときの返り値を表していますUserDetailedNotMeWithRelationsはログインして他者に対してusers/showを呼んだときの返り値を表していますMeDetailedはiや自分に対してusers/showを呼んだときの返り値を表していますUserDetailed.toJsonはUserDetailedを実装したクラスを与えられたMapのキーに応じて返しますUserLiteとUserDetailedはUserを実装していますUser.toJsonはUserを実装したクラスを与えられたMapのキーに応じて返します