Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partial update for svelte3 #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Foxcapades
Copy link

Updated import for the new svelte 3 package structure.

Using this update in my current builds without issue.

G.task('compile-svelte', () => G.src('./src/**/*.svelte')
  .pipe(svelte({css: false, format: 'cjs'}))
  .pipe(G.dest(dirs.work)));
[08:27:29] Starting 'compile-svelte'...
[08:27:35] Finished 'compile-svelte' after 5.39 s

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling bda72cd on Foxcapades:master into 791ab3f on shinnn:master.

@Foxcapades Foxcapades requested a review from shinnn February 24, 2020 15:34
@@ -115,7 +116,7 @@ ${errors.map((line, i) => `${i + 1}. ${line}`).join('\n')}`);
try {
result = compile(preprocessOption ? (await preprocess(file.contents.toString(), preprocessOption)).toString() : file.contents.toString(), {
filename: file.path,
...options
...omit(options, ['preprocess'])
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omitted because the svelte compiler was throwing an error for the existence of the 'preprocess' entry in the options.

@Foxcapades Foxcapades mentioned this pull request Feb 24, 2020
@criticalmash
Copy link

Hi, any reason why this has not merged? I have a site that I'd like to upgrade to Svelte 3.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants