Fixes discarding host events when from_q queue is None #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a grave bug because every time ask_reinit() is called from create_message() and self.from_q is None, the complete message is discarded due a captured Exception. ``` 2014-09-26 14:18:39,417 [1411733919] Error : [broker-master] [Canopsis] Error: there was an error while trying to create message for host 2014-09-26 14:18:39,417 [1411733919] Error : [broker-master] [Canopsis] Error: 'NoneType' object has no attribute 'put' ```
|
You are right @Seb-Solon, it's a bad idea to just ignore the error. I've just modified the patch in order to warn about the attribute error. It's better than nothing. Also, if you don't capture the error, you will probably lose a lot of messages because there is a huge global exception around the create_message() method, which makes a call to the ask_reinit buggy method. |
|
Any advance on this? Look at my logs with the patch applied: |
|
looking at this.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a grave bug because every time ask_reinit() is called from create_message() and self.from_q is None, the complete message is discarded due a captured Exception.