KOMORANAdmin을 KOMORAN repository로 통합 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KOMORAN Admin v0.1 (migrated from 9bow/DictAdmin) * dic.word 파일 관리 기능 이전
KOMORAN Admin v0.5
KOMORAN Admin v1.2
파일 단위 형태소 분석 기능 추가
|
일요일까지 보고 코멘트 남기겠습니당 |
9bow
reviewed
Apr 4, 2020
Comment on lines
+21
to
+22
| include 'admin' | ||
| include 'admin' |
There was a problem hiding this comment.
admin 모듈이 한 번만 추가되어도 될 것 같습니다.
Suggested change
| include 'admin' | |
| include 'admin' | |
| include 'admin' |
9bow
reviewed
Apr 4, 2020
|
|
||
| dependencies { | ||
| // use latest KOMORAN | ||
| compile 'com.github.shin285:KOMORAN:3.3.8' |
There was a problem hiding this comment.
이 부분은 merge 후 추가 수정을 하는 것으로 @shin285 님께서 말씀해주셨습니다.
9bow
approved these changes
Apr 4, 2020
gamamoe
approved these changes
Apr 5, 2020
shin285
added a commit
that referenced
this pull request
Apr 15, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈 또는 PR 번호
Resolve #104
PR 종류
PR 설명