Hw12 calendar #12
Merged
Hw12 calendar #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimmy8
commented
Nov 17, 2023
|
|
||
| install-lint-deps: | ||
| (which golangci-lint > /dev/null) || curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell go env GOPATH)/bin v1.50.1 | ||
| (which golangci-lint > /dev/null) || curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell go env GOPATH)/bin v1.54.2 |
There was a problem hiding this comment.
Пришлось бампнуть версию, наткнулся на ошибку golangci/golangci-lint#3107
vladislavmass
approved these changes
Nov 19, 2023
| h.ServeHTTP(recorder, r) | ||
|
|
||
| var msgBuilder strings.Builder | ||
| for _, part := range []string{ |
There was a problem hiding this comment.
Данный лог не позволит нам никаким образом идентифицировать клиента, так что было бы неплохо добавить в лог вывод IP
|
|
||
| "github.com/spf13/viper" | ||
| ) | ||
|
|
||
| // При желании конфигурацию можно вынести в internal/config. | ||
| // Организация конфига в main принуждает нас сужать API компонентов, использовать | ||
| // при их конструировании только необходимые параметры, а также уменьшает вероятность циклической зависимости. | ||
| type Config struct { |
There was a problem hiding this comment.
Конфиг лучше держать в отдельном пакете. Так как cmd может быть несколько, а конфиг у них будет 1
shimmy8
force-pushed
the
hw12_calendar
branch
from
be93cc2
to
3f1812d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Домашнее задание №12 «Заготовка сервиса Календарь»
Критерии оценки
на пакеты по определенной логике) - до 2 баллов
Реализовано хранилище:
Зачёт от 7 баллов