Places: Use coloful "pictures" folder icon #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use same icon as upstream uses for `folder-pictures` at 16px-24px.
|
Looks good to me! Hopefully Simon doesn't mind all these merges. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use same icon as upstream uses for
folder-picturesat 16px-24px.This changes the look in the Places sidebar and for the folder icon in the file manager at these small pixel sizes.
A few possible issues. This doesn't match the image mimetype like the current one does. It is the same icon that was use for the "Graphics" category so it might be good to come up with something different for that category in the future. Just wanted to bring those up in case anyone thought these might be reasons not to merge this.