Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing gtk-copy --> edit-copy symlink #359

Closed
jesusofsuburbs opened this issue Dec 18, 2022 · 4 comments · Fixed by #361
Closed

Missing gtk-copy --> edit-copy symlink #359

jesusofsuburbs opened this issue Dec 18, 2022 · 4 comments · Fixed by #361

Comments

@jesusofsuburbs
Copy link

It seems that for the other action icons, there's a missing symlink for gtk-copy pointing to edit-copy, which renders the icons for the copy action in GTK3's context menus as a 'missing icon' icon instead (I use gtk3-classic, rather than upstream gtk3). The other actions (e.g. gtk-open) do seem to have symlinks installed. This applies to all icon sizes, from what I can gather.

@newhoa
Copy link
Contributor

newhoa commented Dec 22, 2022

Thanks for reporting!

That's a simple fix! But while adding the gtk-copy symlink, it made me wonder... are these icons ever used beyond menu and button sizes (maybe toolbar)? Wonder if it would be safe to remove 64px and above versions and just keep 48px and below (or maybe 24px and below?).

newhoa added a commit to newhoa/elementary-xfce that referenced this issue Dec 22, 2022
Adds missing gtk-copy (symlinked to edit-copy)

Removes 64px and above gtk- prefixed icons, as they seem
to only be used at menu and button sizes.

Fixes shimmerproject#359
@newhoa
Copy link
Contributor

newhoa commented Dec 22, 2022

Created a PR here if anyone would like to test it out (or if anyone has any objections to removing the larger sized symlinks, let me know if it causes issues).

newhoa added a commit to newhoa/elementary-xfce that referenced this issue Dec 22, 2022
Adds missing gtk-copy (symlinked to edit-copy)

Removes 64px and above gtk- prefixed icons, as they seem
to only be used at menu and button sizes.

Fixes shimmerproject#359
newhoa added a commit to newhoa/elementary-xfce that referenced this issue Dec 22, 2022
Adds missing gtk-copy (symlinked to edit-copy)

Removes some duplicate gtk- prefixed icons in /apps.
Removes 64px and above gtk- prefixed icons,
as they seem to only be used at menu and button sizes.

Fixes shimmerproject#359
@jesusofsuburbs
Copy link
Author

Thanks for reporting!

That's a simple fix! But while adding the gtk-copy symlink, it made me wonder... are these icons ever used beyond menu and button sizes (maybe toolbar)? Wonder if it would be safe to remove 64px and above versions and just keep 48px and below (or maybe 24px and below?).

Don't quote me on this, but I believe 48px is the largest size used - at least, I could only think of Thunar's file operation dialog, but that's probably using the 48px one.

@newhoa
Copy link
Contributor

newhoa commented Dec 23, 2022

@jesusofsuburbs Ok thanks! I think that PR should do it so hopefully it'll be in the next release.

ochosi pushed a commit to newhoa/elementary-xfce that referenced this issue Mar 29, 2023
Adds missing gtk-copy (symlinked to edit-copy)

Removes some duplicate gtk- prefixed icons in /apps.
Removes 64px and above gtk- prefixed icons,
as they seem to only be used at menu and button sizes.

Fixes shimmerproject#359
ochosi pushed a commit that referenced this issue Mar 29, 2023
Adds missing gtk-copy (symlinked to edit-copy)

Removes some duplicate gtk- prefixed icons in /apps.
Removes 64px and above gtk- prefixed icons,
as they seem to only be used at menu and button sizes.

Fixes #359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants