Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action icons #346

Closed
mare1203 opened this issue Sep 30, 2022 · 3 comments · Fixed by #352
Closed

Action icons #346

mare1203 opened this issue Sep 30, 2022 · 3 comments · Fixed by #352

Comments

@mare1203
Copy link

When panel row size is set to 26, restart action icon is monochromatic. When I set row size to 36 all action icons are in color. I use xfce elementary darker mode.
Screenshot_2022-09-30_17-01-27
Screenshot_2022-09-30_17-20-41
Also, i found in Transmission play and pause icons are monochromatics, while remove icon is red... I don't know about you guys, but my opinion is that for consistency all these icons should be colorful...
Screenshot_2022-09-30_18-44-13
One more thing, I think this icon looks outdated and needs a redesign.
image

newhoa added a commit to newhoa/elementary-xfce that referenced this issue Oct 7, 2022
The 'darker' variant of the theme used fake monochrome icons for some
toolbar icons.
This served as a workaround in some cases where icons were hard to see.
It also was meant to give toolbars a symbolic-icon look. But since many
times they are mixed with color icons, it looks very inconsistent.
And now that we have real symbolic icons where the developers choose
to use them, they don't seem necessary to use in that case.

With updates over the last year, the hard-to-see icons should now be good
enough in the base theme that these special and fake monochrome icons
can be removed.

The only thing left to this variant after that was the blue wifi icons
at 16px for the panel. These were moved to 'elementary Xfce dark'
to replace the fake monochrome icons there.

Similar to what was done with the 'darkest' variant, a
deprecation message was added to the description telling users
to now use 'elementary Xfce dark'

This now leave the theme with two variants, regular and dark.
The difference being light and dark panel icons.

Fixes shimmerproject#346
newhoa added a commit to newhoa/elementary-xfce that referenced this issue Oct 7, 2022
The 'darker' variant of the theme used fake monochrome icons for some
toolbar icons.
This served as a workaround in some cases where icons were hard to see.
It also was meant to give toolbars a symbolic-icon look. But since many
times they are mixed with color icons, it looks very inconsistent.
And now that we have real symbolic icons where the developers choose
to use them, they don't seem necessary to use in that case.

With updates over the last year, the hard-to-see icons should now be good
enough in the base theme that these special and fake monochrome icons
can be removed.

The only thing left to this variant after that was the blue wifi icons
at 16px for the panel. These were moved to 'elementary Xfce dark'
to replace the fake monochrome icons there.

Similar to what was done with the 'darkest' variant, a
deprecation message was added to the description telling users
to now use 'elementary Xfce dark'

This now leave the theme with two variants, regular and dark.
The difference being light and dark panel icons.

Fixes shimmerproject#346
@newhoa
Copy link
Contributor

newhoa commented Oct 7, 2022

@mare1203 Thanks for reporting.

See how things look with this branch if you have some time. The only difference between dark and darker variants are the monochromatic action icons (and 16px panel network icons). That branch simple removes/deprecates darker.

It really should just have the same effect as switching to elementary Xfce dark (minus the wifi icon) so at the very least try that variant and see if it fixed the issues for you.

As for the Session and Startup icon, I think it should be updated but I think you should open a separate issue for that.

Thanks.

@mare1203
Copy link
Author

mare1203 commented Oct 8, 2022

@mare1203 Thanks for reporting.

See how things look with this branch if you have some time. The only difference between dark and darker variants are the monochromatic action icons (and 16px panel network icons). That branch simple removes/deprecates darker.

It really should just have the same effect as switching to elementary Xfce dark (minus the wifi icon) so at the very least try that variant and see if it fixed the issues for you.

As for the Session and Startup icon, I think it should be updated but I think you should open a separate issue for that.

Thanks.

Thanks for your reply...
I'm using light gtk themes, currently mint y aqua, so I can't really use the dark version of the icon theme... I've checked this branch for a few minutes using elementary xfce that should match the gtk theme... I haven't reset the system so maybe some things not properly shown, but here are a few things that caught my eye:
2022-10-08_18-17

I noticed new icons for libreoffice apps, main icon for startcenter looks kind of strange, I'm used to an empty, white icon without these 6 fields... It seems that this type of icon will remain in the new official icons as well... In my opinion, the impress icon should retain something that is associated with the list as well, not only the graph, but this one certainly looks better than the current one...

newhoa added a commit to newhoa/elementary-xfce that referenced this issue Nov 1, 2022
With the updates over the last year to reduce the need for the
fake monochromatic toolbar icons, they should be safe to remove,
removing the need for another variant.

The light and dark panel icons do still seem needed in some places,
so they remain. This will leave the theme with two variants:
"elementary Xfce" and "elementary Xfce darker".

Similar to what was done with the 'darkest' variant, a
deprecation message was added to the description telling users
to now use 'elementary Xfce darker'

Fixes shimmerproject#346

These may have been fixed already, but if not will be fixed with this:

Fixes shimmerproject#203
Fixes shimmerproject#216
@newhoa
Copy link
Contributor

newhoa commented Nov 1, 2022

@mare1203 Thanks for the notes and picture!

I made a PR here that will hopefully remove the monochromatic icons from the toolbar, and the action/session icons in the panel. It should also address the wifi icon, although I think what you're seeing there with the darker color is a result of bug in the System Tray Plugin (which was discussed here, and possibly fixed upstream [though unfortunately not updated in the repositories just yet]).

The volume icon may be a concern. I didn't experience what you did with the PR I submitted, but if so we'll need to take care of that.

But hopefully this will end up resolving the issues. If you're able to test it, or eventually use it after the PR is merged, and still have problems please definitely open new issues. Thanks!

newhoa added a commit to newhoa/elementary-xfce that referenced this issue Nov 12, 2022
With the updates over the last year to reduce the need for the
fake monochromatic toolbar icons, they should be safe to remove,
removing the need for another variant.

The light and dark panel icons do still seem needed in some places,
so they remain. This will leave the theme with two variants:
"elementary Xfce" and "elementary Xfce dark".

Similar to what was done with the 'darkest' variant, a
deprecation message was added to the description of darker
telling users to now use 'elementary Xfce dark'

Fixes shimmerproject#346

These may have been fixed already, but if not will be fixed with this:

Fixes shimmerproject#203
Fixes shimmerproject#216
ochosi pushed a commit to newhoa/elementary-xfce that referenced this issue Nov 16, 2022
With the updates over the last year to reduce the need for the
fake monochromatic toolbar icons, they should be safe to remove,
removing the need for another variant.

The light and dark panel icons do still seem needed in some places,
so they remain. This will leave the theme with two variants:
"elementary Xfce" and "elementary Xfce dark".

Similar to what was done with the 'darkest' variant, a
deprecation message was added to the description of darker
telling users to now use 'elementary Xfce dark'

Fixes shimmerproject#346

These may have been fixed already, but if not will be fixed with this:

Fixes shimmerproject#203
Fixes shimmerproject#216
ochosi pushed a commit to newhoa/elementary-xfce that referenced this issue Nov 16, 2022
With the updates over the last year to reduce the need for the
fake monochromatic toolbar icons, they should be safe to remove,
removing the need for another variant.

The light and dark panel icons do still seem needed in some places,
so they remain. This will leave the theme with two variants:
"elementary Xfce" and "elementary Xfce dark".

Similar to what was done with the 'darkest' variant, a
deprecation message was added to the description of darker
telling users to now use 'elementary Xfce dark'

Fixes shimmerproject#346

These may have been fixed already, but if not will be fixed with this:

Fixes shimmerproject#203
Fixes shimmerproject#216
ochosi pushed a commit that referenced this issue Nov 16, 2022
With the updates over the last year to reduce the need for the
fake monochromatic toolbar icons, they should be safe to remove,
removing the need for another variant.

The light and dark panel icons do still seem needed in some places,
so they remain. This will leave the theme with two variants:
"elementary Xfce" and "elementary Xfce dark".

Similar to what was done with the 'darkest' variant, a
deprecation message was added to the description of darker
telling users to now use 'elementary Xfce dark'

Fixes #346

These may have been fixed already, but if not will be fixed with this:

Fixes #203
Fixes #216
newhoa added a commit to newhoa/elementary-xfce that referenced this issue Jun 30, 2024
Use full color icons for volume. These icons match
the rest of the color theme better and are easier
to see in both light and dark themes.

Remove same-named monochromatic icons from the `panel` folder.
Symbolic icons (which automatically recolorize) are now common
so these monochromatic icons should no longer be needed.
In places where developers have chosen not to use symbolic icons,
we shouldn't force the look. This also solves an issue where
the monochromatic icons were difficult to see with mixed
light and dark themes (especially with per-app
light and dark theme preferences becoming more common).

Symlink `-panel` suffixed icons to the new
colorized icons at 16px, 22px. These still
may be used for ayatana indicators. Not sure
if any sizes other than 22px really needed.

Fixes shimmerproject#416
Fixes shimmerproject#90
Address part of shimmerproject#362
Addresses part of shimmerproject#346
Newer solution to shimmerproject#180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants