-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action icons #346
Comments
The 'darker' variant of the theme used fake monochrome icons for some toolbar icons. This served as a workaround in some cases where icons were hard to see. It also was meant to give toolbars a symbolic-icon look. But since many times they are mixed with color icons, it looks very inconsistent. And now that we have real symbolic icons where the developers choose to use them, they don't seem necessary to use in that case. With updates over the last year, the hard-to-see icons should now be good enough in the base theme that these special and fake monochrome icons can be removed. The only thing left to this variant after that was the blue wifi icons at 16px for the panel. These were moved to 'elementary Xfce dark' to replace the fake monochrome icons there. Similar to what was done with the 'darkest' variant, a deprecation message was added to the description telling users to now use 'elementary Xfce dark' This now leave the theme with two variants, regular and dark. The difference being light and dark panel icons. Fixes shimmerproject#346
The 'darker' variant of the theme used fake monochrome icons for some toolbar icons. This served as a workaround in some cases where icons were hard to see. It also was meant to give toolbars a symbolic-icon look. But since many times they are mixed with color icons, it looks very inconsistent. And now that we have real symbolic icons where the developers choose to use them, they don't seem necessary to use in that case. With updates over the last year, the hard-to-see icons should now be good enough in the base theme that these special and fake monochrome icons can be removed. The only thing left to this variant after that was the blue wifi icons at 16px for the panel. These were moved to 'elementary Xfce dark' to replace the fake monochrome icons there. Similar to what was done with the 'darkest' variant, a deprecation message was added to the description telling users to now use 'elementary Xfce dark' This now leave the theme with two variants, regular and dark. The difference being light and dark panel icons. Fixes shimmerproject#346
@mare1203 Thanks for reporting. See how things look with this branch if you have some time. The only difference between It really should just have the same effect as switching to As for the Thanks. |
Thanks for your reply... I noticed new icons for libreoffice apps, main icon for startcenter looks kind of strange, I'm used to an empty, white icon without these 6 fields... It seems that this type of icon will remain in the new official icons as well... In my opinion, the impress icon should retain something that is associated with the list as well, not only the graph, but this one certainly looks better than the current one... |
With the updates over the last year to reduce the need for the fake monochromatic toolbar icons, they should be safe to remove, removing the need for another variant. The light and dark panel icons do still seem needed in some places, so they remain. This will leave the theme with two variants: "elementary Xfce" and "elementary Xfce darker". Similar to what was done with the 'darkest' variant, a deprecation message was added to the description telling users to now use 'elementary Xfce darker' Fixes shimmerproject#346 These may have been fixed already, but if not will be fixed with this: Fixes shimmerproject#203 Fixes shimmerproject#216
@mare1203 Thanks for the notes and picture! I made a PR here that will hopefully remove the monochromatic icons from the toolbar, and the action/session icons in the panel. It should also address the wifi icon, although I think what you're seeing there with the darker color is a result of bug in the System Tray Plugin (which was discussed here, and possibly fixed upstream [though unfortunately not updated in the repositories just yet]). The volume icon may be a concern. I didn't experience what you did with the PR I submitted, but if so we'll need to take care of that. But hopefully this will end up resolving the issues. If you're able to test it, or eventually use it after the PR is merged, and still have problems please definitely open new issues. Thanks! |
With the updates over the last year to reduce the need for the fake monochromatic toolbar icons, they should be safe to remove, removing the need for another variant. The light and dark panel icons do still seem needed in some places, so they remain. This will leave the theme with two variants: "elementary Xfce" and "elementary Xfce dark". Similar to what was done with the 'darkest' variant, a deprecation message was added to the description of darker telling users to now use 'elementary Xfce dark' Fixes shimmerproject#346 These may have been fixed already, but if not will be fixed with this: Fixes shimmerproject#203 Fixes shimmerproject#216
With the updates over the last year to reduce the need for the fake monochromatic toolbar icons, they should be safe to remove, removing the need for another variant. The light and dark panel icons do still seem needed in some places, so they remain. This will leave the theme with two variants: "elementary Xfce" and "elementary Xfce dark". Similar to what was done with the 'darkest' variant, a deprecation message was added to the description of darker telling users to now use 'elementary Xfce dark' Fixes shimmerproject#346 These may have been fixed already, but if not will be fixed with this: Fixes shimmerproject#203 Fixes shimmerproject#216
With the updates over the last year to reduce the need for the fake monochromatic toolbar icons, they should be safe to remove, removing the need for another variant. The light and dark panel icons do still seem needed in some places, so they remain. This will leave the theme with two variants: "elementary Xfce" and "elementary Xfce dark". Similar to what was done with the 'darkest' variant, a deprecation message was added to the description of darker telling users to now use 'elementary Xfce dark' Fixes shimmerproject#346 These may have been fixed already, but if not will be fixed with this: Fixes shimmerproject#203 Fixes shimmerproject#216
With the updates over the last year to reduce the need for the fake monochromatic toolbar icons, they should be safe to remove, removing the need for another variant. The light and dark panel icons do still seem needed in some places, so they remain. This will leave the theme with two variants: "elementary Xfce" and "elementary Xfce dark". Similar to what was done with the 'darkest' variant, a deprecation message was added to the description of darker telling users to now use 'elementary Xfce dark' Fixes #346 These may have been fixed already, but if not will be fixed with this: Fixes #203 Fixes #216
Use full color icons for volume. These icons match the rest of the color theme better and are easier to see in both light and dark themes. Remove same-named monochromatic icons from the `panel` folder. Symbolic icons (which automatically recolorize) are now common so these monochromatic icons should no longer be needed. In places where developers have chosen not to use symbolic icons, we shouldn't force the look. This also solves an issue where the monochromatic icons were difficult to see with mixed light and dark themes (especially with per-app light and dark theme preferences becoming more common). Symlink `-panel` suffixed icons to the new colorized icons at 16px, 22px. These still may be used for ayatana indicators. Not sure if any sizes other than 22px really needed. Fixes shimmerproject#416 Fixes shimmerproject#90 Address part of shimmerproject#362 Addresses part of shimmerproject#346 Newer solution to shimmerproject#180
When panel row size is set to 26, restart action icon is monochromatic. When I set row size to 36 all action icons are in color. I use xfce elementary darker mode.
Also, i found in Transmission play and pause icons are monochromatics, while remove icon is red... I don't know about you guys, but my opinion is that for consistency all these icons should be colorful...
One more thing, I think this icon looks outdated and needs a redesign.
The text was updated successfully, but these errors were encountered: