Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome Disks icon doesn't look good on white background #215

Closed
philipzae opened this issue Apr 22, 2020 · 4 comments · Fixed by #384
Closed

Gnome Disks icon doesn't look good on white background #215

philipzae opened this issue Apr 22, 2020 · 4 comments · Fixed by #384

Comments

@philipzae
Copy link

The icon for Disks (Icon=org.gnome.DiskUtility) doesn't go well with the icon theme and also is doesn't appear well on light on white backgrounds (the one below 'Bluetooth Adapters')
preview

preview

A simple redirect from /devices/48/drive-harddisk.png would be sufficient to fix this.

@m4u9
Copy link
Member

m4u9 commented Apr 22, 2020

Gnome developers get cranky when we change their icons so i’m reluctant to touch this.

@philipzae
Copy link
Author

We change the Gnome Software icon, so not sure this is any different.

@m4u9
Copy link
Member

m4u9 commented Apr 22, 2020

Yes and i’m not sure that was the right move

@ochosi
Copy link
Member

ochosi commented Jul 4, 2022

I'm not convinced we should override all Gnome application icons, so closing this for now.

@ochosi ochosi closed this as completed Jul 4, 2022
newhoa added a commit to newhoa/elementary-xfce that referenced this issue Jul 19, 2023
New
- Additional Drivers (jockey), uses application-x-firmware mimetype as base
- Gnome Disk Utility, using official disk app but add border making it easier to see (fixes shimmerproject#215)

Updated
- USB Creator / Ubiquity, new arrow type and gradients
- Keyring, use semi-transparent borders (sharper on dark backgrounds)

Removed / Changed
- Use old totem icon for Xine and remove Xine symlink (totem icon wasn't being used)
bluesabre pushed a commit that referenced this issue Sep 6, 2023
New
- Additional Drivers (jockey), uses application-x-firmware mimetype as base
- Gnome Disk Utility, using official disk app but add border making it easier to see (fixes #215)

Updated
- USB Creator / Ubiquity, new arrow type and gradients
- Keyring, use semi-transparent borders (sharper on dark backgrounds)

Removed / Changed
- Use old totem icon for Xine and remove Xine symlink (totem icon wasn't being used)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants