Massive feature lift #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves "success friend" from executing regardless of failures.
Rate Limiting: checks `X-Ratelimit-Remaining` in the header response and determines how long to sleep based on reset time. Repo Checks: if repo is already cloned, pull latest head instead of cloning. Retry Logic: Retries 3 times to GET the repo response from GitHub. Spinner: Adding a new spinner for cleaning CLT usage, saves on amount of lines outputted previously. feat: filter by language function Adding ability to filter []RepoModel by language
test: initial tests
chore: cleaning up order of variables and params
When implementing the CommandExecutor struct, a option to run commands in current directory was neglected. After adding it and correctly calling it in the if/else for git clones resolved the issue. Using atomics to increment the counter to help resolve issue with spinner not appearing when executing `CloneReposFromJson()`
azemetre
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features:
GetRepos()enhancements:X-Ratelimit-Remainingheader responserepos.jsonfile from fetched reposCloneReposFromJson()enhancements:RepoByLanguage()allows ability to further filter fetched repos more. Should allow composability when working with Cobra commands