Skip author/assignee automention

automention.js

@@ -1,15 +1,17 @@
 const { isAutomention, formatAutomention } = require('./comments');
 
-function getOwners(issueLabels, labelToOwners, log) {
-  log.info('Getting unique owners', issueLabels, labelToOwners);
-  const uniqueOwners = new Set();
+function usersToNotify(issueLabels, labelToUsers, skipNotify, log) {
+  log.info('Getting users to notify', issueLabels, labelToUsers, skipNotify);
+  const uniqueUsers = new Set();
   issueLabels.forEach(label => {
-    const owners = labelToOwners[label];
-    if (owners) {
-      owners.forEach(owner => uniqueOwners.add(owner));
+    const users = labelToUsers[label];
+    if (users) {
+      users.forEach(
+        user => !skipNotify.includes(user) && uniqueUsers.add(user)
+      );
     }
   });
-  return Array.from(uniqueOwners).sort();
+  return Array.from(uniqueUsers).sort();
 }
 
 async function automention({
@@ -30,9 +32,12 @@ async function automention({
 
   const fullIssue = (await issuesApi.get(issue)).data;
   log.debug(`Full issue state: ${fullIssue.state}`);
+  const skipNotify = [fullIssue.user, ...fullIssue.assignees].map(
+    user => user.login
+  );
 
-  const owners = getOwners(labels, config, log);
-  const body = owners.length ? formatAutomention(owners) : null;
+  const users = usersToNotify(labels, config, skipNotify, log);
+  const body = users.length ? formatAutomention(users) : null;
 
   if (!automentionComments.length) {
     log.debug('No automention comments');

automention.test.js

@@ -8,6 +8,19 @@ const issue = {
   number: 'number'
 };
 
+const FULL_ISSUE = {
+  OPEN: {
+    state: 'open',
+    user: { login: 'random' },
+    assignees: []
+  },
+  CLOSED: {
+    state: 'closed',
+    user: { login: 'random' },
+    assignees: []
+  }
+};
+
 describe('automention', () => {
   beforeEach(() => {
     input = {
@@ -20,7 +33,7 @@ describe('automention', () => {
       issuesApi: {
         get: jest.fn().mockReturnValue(
           Promise.resolve({
-            data: { state: 'open' }
+            data: FULL_ISSUE.OPEN
           })
         ),
         createComment: jest.fn(),
@@ -36,7 +49,7 @@ describe('automention', () => {
     };
   });
 
-  fit('handles multiple labels, uniquifying users and sorting them', async () => {
+  it('handles multiple labels, uniquifying users and sorting them', async () => {
     input.labels = ['bug', 'whatever', 'feature'];
     input.existingComments = [];
     await automention(input);
@@ -46,6 +59,25 @@ describe('automention', () => {
     });
   });
 
+  it('excludes issue author and assignees from automention', async () => {
+    input.labels = ['bug', 'whatever', 'feature'];
+    input.existingComments = [];
+    input.issuesApi.get.mockReturnValue(
+      Promise.resolve({
+        data: {
+          state: 'open',
+          user: { login: 'shilman' },
+          assignees: [{ login: 'igor-dv' }]
+        }
+      })
+    );
+    await automention(input);
+    expect(input.issuesApi.createComment).toHaveBeenCalledWith({
+      ...issue,
+      body: `Automention: Hey @ndelangen @tmeasday, you've been tagged! Can you give a hand here?`
+    });
+  });
+
   describe('no automention comments', () => {
     beforeEach(() => {
       input.existingComments = [
@@ -77,7 +109,7 @@ describe('automention', () => {
       input.labels = ['bug'];
       input.issuesApi.get.mockReturnValue(
         Promise.resolve({
-          data: { state: 'closed' }
+          data: FULL_ISSUE.CLOSED
         })
       );
       await automention(input);
@@ -132,7 +164,7 @@ describe('automention', () => {
       input.labels = ['bug'];
       input.issuesApi.get.mockReturnValue(
         Promise.resolve({
-          data: { state: 'closed' }
+          data: FULL_ISSUE.CLOSED
         })
       );
       await automention(input);