Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NarouResolver: 作品に含まれる要素のキーワードに含まれるnbspを除去 #1345

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

shibafu528
Copy link
Member

fix #1323

作品に含まれる要素によって設定されたキーワードが   区切りで出力されていて、うまくタグ分割できていなかったのを修正しました。

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.85%. Comparing base (84a83d4) to head (5ba8ac1).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1345   +/-   ##
==========================================
  Coverage      39.85%   39.85%           
  Complexity      1057     1057           
==========================================
  Files            137      137           
  Lines           3849     3849           
==========================================
  Hits            1534     1534           
  Misses          2315     2315           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@unarist unarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diffを読んだだけですが妥当そうに見えました

@shibafu528 shibafu528 merged commit 3d2a71d into develop Nov 24, 2024
4 checks passed
@shibafu528 shibafu528 deleted the fix/1323-narou-zap-nbsp branch November 24, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NarouResolver タグが合体してることがある
2 participants