Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve js engine support (and run tests) in pre-ES2024 envs #847

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

slevithan
Copy link
Contributor

@slevithan slevithan commented Nov 24, 2024

Bumps oniguruma-to-es to patch v0.6.1 to improve JS engine support when using target: 'ES2018'. This includes cases when target: 'auto' is used in pre-ES2024 environments like Node.js 18. I've also updated the JS engine tests to run in such environments.

Copy link

netlify bot commented Nov 24, 2024

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit 8c59802
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/6742fee517e7a600082a59fe
😎 Deploy Preview https://deploy-preview-847--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 24, 2024

Deploy Preview for shiki-next ready!

Name Link
🔨 Latest commit 8c59802
🔍 Latest deploy log https://app.netlify.com/sites/shiki-next/deploys/6742fee5a2c3e3000803b4aa
😎 Deploy Preview https://deploy-preview-847--shiki-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.09%. Comparing base (fc87512) to head (8c59802).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #847   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files          83       83           
  Lines        6927     6927           
  Branches     1458     1458           
=======================================
  Hits         6587     6587           
  Misses        331      331           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@antfu antfu merged commit 76cbc7e into shikijs:main Nov 25, 2024
14 checks passed
@slevithan slevithan deleted the jsengine branch November 26, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants