Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase off of current master, then replace defcustom with keyword #1

Open
wants to merge 11 commits into
base: data-coding-system
Choose a base branch
from

Conversation

titaniumbones
Copy link

see discussion in tkf#85 for details -- I am hoping this new code meets all of your requirements and is a little more consistent with the current usage of request.

xuchunyang and others added 10 commits November 18, 2017 02:05
26-pretest is now 26.1
fix obsolete EMACS_EVM value
Non-ascii strings in JSON data would be unicoded when POSTing curl with JSON data because
buffer-file-coding-system in data buffer is 'binary.

But to change this code is not good for web page whose encoding is other encoding, so
set encode in variable request-conding-system.

(seq request-conding-system 'utf-8)
Not tested yet!

This code removes the new `request-coding-system` defcustom, and
instead uses a keyword parameter to the main `request` function. Since
this parameter needs to be passed down the chain several times I'm not
entirely certain that I've made the changes everywhere they need to be
made.

This commit also shifts the default form 'binary to 'utf-8.
@titaniumbones titaniumbones changed the title rebase off of current maste,r then replace defcusom with keyword rebase off of current master, then replace defcustom with keyword Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants