Reverse Global Tenant check logic in cancel task endpoint #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to cancel a task by DELETEing at the tenant specific task API endpoint would result in No Such Task being returned. It appears that this is because of a reversed logic check, which prevents this endpoint from being a workaround to delete global tasks. Instead, it ONLY allows the cancellation of global tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to cancel a task by DELETEing at the tenant specific task API
endpoint would result in No Such Task being returned. It appears that
this is because of a reversed logic check, which prevents this endpoint
from being a workaround to delete global tasks. Instead, it ONLY allows
the cancellation of global tasks.
Addresses #647