Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider what it would look like to allow tools to provide types to the config #1

Closed
orta opened this issue Nov 5, 2018 · 1 comment

Comments

@orta
Copy link
Member

orta commented Nov 5, 2018

Somehow the runtime/compilation aspect will need to expose the set of library targets to the eval phase

#if canImport(PackageConfig)
import PackageConfig
import Danger

// Generic
let config = PackageConfig([
    "linter": ["rules": ["allowSomething"]]
])

// Extension provided by Danger
config.danger = [
   .disabled(true)
]
#endif

The settings will need to be coerced though the JSON and back somehow, but maybe codable can do that?

@orta
Copy link
Member Author

orta commented Mar 24, 2019

This is in with #4

@orta orta closed this as completed Mar 24, 2019
orta pushed a commit that referenced this issue May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant