Skip to content

Commit

Permalink
Revert 97c6a72.
Browse files Browse the repository at this point in the history
That commit prevented 'sdist' from printing distribution quality warnings.
  • Loading branch information
23Skidoo committed Oct 30, 2014
1 parent ee6e478 commit 1f41dbf
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
4 changes: 2 additions & 2 deletions Cabal/Distribution/Simple/SrcDist.hs
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ import Distribution.Simple.Utils
, installOrdinaryFiles, installMaybeExecutableFiles
, findFile, findFileWithExtension, matchFileGlob
, withTempDirectory, defaultPackageDesc
, die, warn, notice, setupMessage )
, die, warn, notice, info, setupMessage )
import Distribution.Simple.Setup ( Flag(..), SDistFlags(..)
, fromFlag, flagToMaybe)
import Distribution.Simple.PreProcess ( PPSuffixHandler, ppSuffixes
Expand Down Expand Up @@ -113,7 +113,7 @@ sdist pkg mb_lbi flags mkTmpDir pps =
case flagToMaybe (sDistDirectory flags) of
Just targetDir -> do
generateSourceDir targetDir pkg'
notice verbosity $ "Source directory created: " ++ targetDir
info verbosity $ "Source directory created: " ++ targetDir

Nothing -> do
createDirectoryIfMissingVerbose verbosity True tmpTargetDir
Expand Down
5 changes: 1 addition & 4 deletions cabal-install/Distribution/Client/SrcDist.hs
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import Distribution.Simple.BuildPaths ( srcPref)
import Distribution.Simple.Program (requireProgram, simpleProgram, programPath)
import Distribution.Simple.Program.Db (emptyProgramDb)
import Distribution.Text ( display )
import Distribution.Verbosity (Verbosity, lessVerbose, normal)
import Distribution.Verbosity (Verbosity)
import Distribution.Version (Version(..), orLaterVersion)

import System.FilePath ((</>), (<.>))
Expand All @@ -53,9 +53,6 @@ sdist flags exflags = do
let outDir = if isOutDirectory then tmpDir else tmpDir </> tarBallName pkg
flags' = (if not needMakeArchive then flags
else flags { sDistDirectory = Flag outDir })
{ sDistVerbosity = Flag $ if verbosity == normal
then lessVerbose verbosity
else verbosity }
unless isListSources $
createDirectoryIfMissingVerbose verbosity True outDir

Expand Down

0 comments on commit 1f41dbf

Please sign in to comment.