Skip to content

Commit

Permalink
updated env to both workflow files
Browse files Browse the repository at this point in the history
  • Loading branch information
shesaave committed Jul 30, 2024
1 parent a84b8c8 commit b5db699
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/test-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- name: Deploy Amazon ECS task definition With Wait For Task Stopped Being False
uses: aws-actions/amazon-ecs-deploy-task-definition@1a69daea10712415b65b5c90f8c41b1b6b556ab5
with:
task-definition: task-definition-run-task.json
task-definition: ${{ env.ECS_TASK_DEFINITION_RUN_TASK }}
cluster: ${{ env.ECS_CLUSTER }}
run-task: true
run-task-subnets: subnet-e5604fce, subnet-fe9355b4, subnet-c49431bc, subnet-392f9b64
Expand All @@ -49,7 +49,7 @@ jobs:
- name: Deploy Amazon ECS task definition With Wait For Task Stopped Being True
uses: aws-actions/amazon-ecs-deploy-task-definition@1a69daea10712415b65b5c90f8c41b1b6b556ab5
with:
task-definition: task-definition-run-task.json
task-definition: ${{ env.ECS_TASK_DEFINITION_RUN_TASK }}
cluster: ${{ env.ECS_CLUSTER }}
run-task: true
run-task-subnets: subnet-e5604fce, subnet-fe9355b4, subnet-c49431bc, subnet-392f9b64
Expand All @@ -61,7 +61,7 @@ jobs:
- name: Deploy Amazon ECS task definition
uses: aws-actions/amazon-ecs-deploy-task-definition@1a69daea10712415b65b5c90f8c41b1b6b556ab5
with:
task-definition: task-definition.json
task-definition: ${{ env.ECS_TASK_DEFINITION }}
service: ${{ env.ECS_SERVICE }}
cluster: ${{ env.ECS_CLUSTER }}
wait-for-service-stability: true
15 changes: 12 additions & 3 deletions test-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,15 @@ on:
branches:
- integ-tests

env:
AWS_REGION: us-west-2
ECR_REPOSITORY: cdk-hnb659fds-container-assets-708414441733-us-west-2
ECS_SERVICE: github-actions-deploy-task-def-integ-test
ECS_CLUSTER: github-actions-deploy-task-def-integ-test
ECS_TASK_DEFINITION: task-definition.json
ECS_TASK_DEFINITION_RUN_TASK: task-definition-run-task.json
CONTAINER_NAME: web

name: Integration Test

jobs:
Expand All @@ -28,7 +37,7 @@ jobs:
- name: Deploy Amazon ECS task definition With Wait For Task Stopped Being False
uses: aws-actions/amazon-ecs-deploy-task-definition@v1
with:
task-definition: task-definition-run-task.json
task-definition: ${{ env.ECS_TASK_DEFINITION_RUN_TASK }}
cluster: ${{ env.ECS_CLUSTER }}
run-task: true
run-task-subnets: subnet-e5604fce, subnet-fe9355b4, subnet-c49431bc, subnet-392f9b64
Expand All @@ -40,7 +49,7 @@ jobs:
- name: Deploy Amazon ECS task definition With Wait For Task Stopped Being True
uses: aws-actions/amazon-ecs-deploy-task-definition@v1
with:
task-definition: task-definition-run-task.json
task-definition: ${{ env.ECS_TASK_DEFINITION_RUN_TASK }}
cluster: ${{ env.ECS_CLUSTER }}
run-task: true
run-task-subnets: subnet-e5604fce, subnet-fe9355b4, subnet-c49431bc, subnet-392f9b64
Expand All @@ -52,7 +61,7 @@ jobs:
- name: Deploy Amazon ECS task definition
uses: aws-actions/amazon-ecs-deploy-task-definition@v1
with:
task-definition: task-definition.json
task-definition: ${{ env.ECS_TASK_DEFINITION }}
service: ${{ env.ECS_SERVICE }}
cluster: ${{ env.ECS_CLUSTER }}
wait-for-service-stability: true

0 comments on commit b5db699

Please sign in to comment.