Skip to content

Commit

Permalink
made changes from comments
Browse files Browse the repository at this point in the history
  • Loading branch information
shesaave committed Jul 31, 2024
1 parent 071cc21 commit 2d78ba5
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 11 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/test-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

- name: Print current build ID
run: |
echo Integration test run: githubactionsamazonecsdeplo-NWcjHIgDJLXw:b758d9f2-aea6-4592-906f-aae8754d98b4
echo Integration test run: githubactionsamazonecsdeplo-NWcjHIgDJLXw:73193632-fdb5-4eea-b8b8-7c9afb374ce0
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v1
Expand All @@ -26,18 +26,18 @@ jobs:
aws-region: us-west-2

- name: Deploy Amazon ECS task definition With Wait For Task Stopped Being False
uses: aws-actions/amazon-ecs-deploy-task-definition@b3a528eb690c86037acd19fd6a2a86337f4e3657
uses: aws-actions/amazon-ecs-deploy-task-definition@1a69daea10712415b65b5c90f8c41b1b6b556ab5
with:
task-definition: task-definition-run-task.json
cluster: github-actions-deploy-task-def-integ-test
run-task: true
run-task-subnets: subnet-e5604fce, subnet-fe9355b4, subnet-c49431bc, subnet-392f9b64
run-task-security-groups: sg-067ebcde49c0f3ad8
run-task-security-groups: sg-067ebcde49c0f3ad8
run-task-launch-type: FARGATE
wait-for-task-stopped: false
wait-for-task-stopped: false

- name: Deploy Amazon ECS task definition With Wait For Task Stopped Being True
uses: aws-actions/amazon-ecs-deploy-task-definition@b3a528eb690c86037acd19fd6a2a86337f4e3657
uses: aws-actions/amazon-ecs-deploy-task-definition@1a69daea10712415b65b5c90f8c41b1b6b556ab5
with:
task-definition: task-definition-run-task.json
cluster: github-actions-deploy-task-def-integ-test
Expand All @@ -48,9 +48,9 @@ jobs:
wait-for-task-stopped: true

- name: Deploy Amazon ECS task definition
uses: aws-actions/amazon-ecs-deploy-task-definition@b3a528eb690c86037acd19fd6a2a86337f4e3657
uses: aws-actions/amazon-ecs-deploy-task-definition@1a69daea10712415b65b5c90f8c41b1b6b556ab5
with:
task-definition: task-definition.json
service: github-actions-deploy-task-def-integ-test
service: github-actions-deploy-task-def-integ-test
cluster: github-actions-deploy-task-def-integ-test
wait-for-service-stability: true
2 changes: 0 additions & 2 deletions task-definition-run-task.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{

"containerDefinitions": [
{
"memory": 32,
Expand All @@ -23,5 +22,4 @@
],
"networkMode": "awsvpc",
"cpu": "256"

}
4 changes: 2 additions & 2 deletions test-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,6 @@ jobs:
uses: aws-actions/amazon-ecs-deploy-task-definition@v1
with:
task-definition: task-definition.json
service: github-actions-deploy-task-def-integ-test
service: github-actions-deploy-task-def-integ-test
cluster: github-actions-deploy-task-def-integ-test
wait-for-service-stability: true
wait-for-service-stability: true

0 comments on commit 2d78ba5

Please sign in to comment.