Some small fixes #33
Some small fixes #33
Conversation
This solved part of the timezone problem and shouldn't cause any other problems Thanks ststeiger in issue sherlock1982#16
|
I will check, thanks! |
|
Hi @sherlock1982 - could you consider please merging this and releasing a new nuget? We have been struggling with code that works with Office365, but fails with Exchange 2010. Specifically, the error was:
After this change that allows setting content type, everything appears working ok. |
|
For now I'm just running this in a private nuget feed on Azure DevOps. |
|
Closing this stale PR |
|
Could we merge instead? Are the issues fixed elsewhere or can I do something to make the PR it acceptable? |
|
@adz they are fixed in this old pr. I'm using a private nuget in the mean time. Seems this repo isn't maintained anymore. Yesterday I closed several stale PR of mine |
1 similar comment
|
@adz they are fixed in this old pr. I'm using a private nuget in the mean time. Seems this repo isn't maintained anymore. Yesterday I closed several stale PR of mine |
|
Oh right. I thought maybe you were a maintainer. Thanks - I'm also using a fork. |
|
Could this be merged @sherlock1982 ? I see you've merged a change recently for 2.0.0-beta3 so this repo doesn't seem entirely dead. Project I'm working on has hit the issue in #16 when running on Linux (CentOS 7 based) and get "An item with the same key has already been added. Key: Dlt/1941" when creating appointments. It would appear that it's this issue. |
|
@tjmoore could you pls resolve conflicts? The issue is that i can't really test it - I don't have on premise exchange and don't have a lot of time. |
|
Thanks @svrooij 👍. How would I build this as a nuget package I can try out, or can it be published anyway? |
|
I will publish tomorrow. Glad this work was helpful :-) |
| message.Content.Headers.Clear(); | ||
| message.Content.Headers.Add("Content-Type", "text/xml; charset=utf-8"); | ||
| //if (!string.IsNullOrEmpty(ContentType)) | ||
| // message.Content.Headers.ContentType = new MediaTypeHeaderValue(ContentType); | ||
|
|
||
| if (!string.IsNullOrEmpty(ContentType)) { | ||
| message.Content.Headers.ContentType = null; | ||
| message.Content.Headers.TryAddWithoutValidation("Content-Type", ContentType); | ||
| } | ||
|
|
This PR will fix 2 small issues:
For the TimeZones I created a small extension so that it doesn't disturb anything, but it doesn't crash on Ubuntu because of adding duplicate TimeZoneId's
You commented out the sending of the headers with the HttpClient, probably because of that they didn't validate in the
MediaTypeHeaderValue. I changed it to just send the Content-Type anyway.